Commit 6535a4b3 authored Sep 23, 2019 by Chris Wilson Committed by Rodrigo Vivi Oct 09, 2019

drm/i915/execlists: Drop redundant list_del_init(&rq->sched.link)



Since amalgamating the queued and active lists in commit 422d7df4
("drm/i915: Replace engine->timeline with a plain list"), performing a
i915_request_submit() will remove the request from the execlists
priority queue.

References: 422d7df4 ("drm/i915: Replace engine->timeline with a plain list")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190923110056.15176-2-chris@chris-wilson.co.uk


(cherry picked from commit 3231f8c0)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

parent a8064d57

drivers/gpu/drm/i915/gt/intel_lrc.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2564,7 +2564,6 @@ static void execlists_cancel_requests(struct intel_engine_cs *engine)
		int i;

		priolist_for_each_request_consume(rq, rn, p, i) {
		list_del_init(&rq->sched.link);
		__i915_request_submit(rq);
		dma_fence_set_error(&rq->fence, -EIO);
		i915_request_mark_complete(rq);

Admin message