powerpc: Cleanup & use pr_devel() in arch/powerpc/mm/slb.c (651e2dd2) · Commits · 戴 / test

pr_debug() can now result in code being generated even when DEBUG is not defined. That's not really desirable in some places. With CONFIG_DYNAMIC_DEBUG=y: size before: text data bss dec hex filename 3261 416 4 3681 e61 arch/powerpc/mm/slb.o size after: text data bss dec hex filename 2861 248 4 3113 c29 arch/powerpc/mm/slb.o Signed-off-by:

Michael Ellerman <michael@ellerman.id.au> Signed-off-by:

Benjamin Herrenschmidt <benh@kernel.crashing.org>

arch/powerpc/mm/slb.c

+3 −10

Original line number	Diff line number	Diff line
		@@ -14,8 +14,6 @@
		* 2 of the License, or (at your option) any later version.
		*/

		#undef DEBUG

		#include <asm/pgtable.h>
		#include <asm/mmu.h>
		#include <asm/mmu_context.h>
		@@ -27,11 +25,6 @@
		#include <linux/compiler.h>
		#include <asm/udbg.h>

		#ifdef DEBUG
		#define DBG(fmt...) printk(fmt)
		#else
		#define DBG pr_debug
		#endif

		extern void slb_allocate_realmode(unsigned long ea);
		extern void slb_allocate_user(unsigned long ea);
		@@ -285,13 +278,13 @@ void slb_initialize(void)
		patch_slb_encoding(slb_compare_rr_to_size,
		mmu_slb_size);

		DBG("SLB: linear LLP = %04lx\n", linear_llp);
		DBG("SLB: io LLP = %04lx\n", io_llp);
		pr_devel("SLB: linear LLP = %04lx\n", linear_llp);
		pr_devel("SLB: io LLP = %04lx\n", io_llp);

		#ifdef CONFIG_SPARSEMEM_VMEMMAP
		patch_slb_encoding(slb_miss_kernel_load_vmemmap,
		SLB_VSID_KERNEL \| vmemmap_llp);
		DBG("SLB: vmemmap LLP = %04lx\n", vmemmap_llp);
		pr_devel("SLB: vmemmap LLP = %04lx\n", vmemmap_llp);
		#endif
		}

Admin message