Commit 651b1f12 authored Aug 10, 2009 by Magnus Damm Committed by Rafael J. Wysocki Aug 10, 2009

PM / Driver Core: Kill dev_pm_ops platform warning for now



Commit 783ea7d4
(Driver Core: Rework platform suspend/resume, print warning)
added a warning message printed for platform drivers that use the
legacy PM callbacks rather than struct dev_pm_ops.  Unfortunately,
this resulted in some confusion and made some people try to convert
drivers by replacing the old callbacks with struct dev_pm_ops in
automatic way, which generally is not a good idea.

Remove the platform device runtime dev_pm_ops warning for now,
because it's annoying to users and it's not really necessary right
now.

[rjw: Modified the changelog to be more informative.]

Signed-off-by: Magnus Damm <damm@igel.co.jp>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

parent 85dfd81d

drivers/base/platform.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -483,9 +483,6 @@ int platform_driver_register(struct platform_driver *drv)
		drv->driver.remove = platform_drv_remove;
		if (drv->shutdown)
		drv->driver.shutdown = platform_drv_shutdown;
		if (drv->suspend \|\| drv->resume)
		pr_warning("Platform driver '%s' needs updating - please use "
		"dev_pm_ops\n", drv->driver.name);

		return driver_register(&drv->driver);
		}

Admin message