Commit 6514890f authored Feb 20, 2015 by Neal Cardwell Committed by David S. Miller Feb 22, 2015

tcp: fix tcp_should_expand_sndbuf() to use tcp_packets_in_flight()



tcp_should_expand_sndbuf() does not expand the send buffer if we have
filled the congestion window.

However, it should use tcp_packets_in_flight() instead of
tp->packets_out to make this check.

Testing has established that the difference matters a lot if there are
many SACKed packets, causing a needless performance shortfall.

Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Nandita Dukkipati <nanditad@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 52d6c8c6

net/ipv4/tcp_input.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4770,7 +4770,7 @@ static bool tcp_should_expand_sndbuf(const struct sock *sk)
		return false;

		/* If we filled the congestion window, do not expand. */
		if (tp->packets_out >= tp->snd_cwnd)
		if (tcp_packets_in_flight(tp) >= tp->snd_cwnd)
		return false;

		return true;

Admin message