Commit 651438bb authored Feb 15, 2018 by Wen Xiong Committed by Keith Busch Mar 01, 2018

nvme-pci: Fix EEH failure on ppc



Triggering PPC EEH detection and handling requires a memory mapped read
failure. The NVMe driver removed the periodic health check MMIO, so
there's no early detection mechanism to trigger the recovery. Instead,
the detection now happens when the nvme driver handles an IO timeout
event. This takes the pci channel offline, so we do not want the driver
to proceed with escalating its own recovery efforts that may conflict
with the EEH handler.

This patch ensures the driver will observe the channel was set to offline
after a failed MMIO read and resets the IO timer so the EEH handler has
a chance to recover the device.

Signed-off-by: Wen Xiong <wenxiong@linux.vnet.ibm.com>
[updated change log]
Signed-off-by: Keith Busch <keith.busch@intel.com>

parent 468f0987

drivers/nvme/host/pci.c

+7 −6

Original line number	Diff line number	Diff line
		@@ -1153,12 +1153,6 @@ static bool nvme_should_reset(struct nvme_dev *dev, u32 csts)
		if (!(csts & NVME_CSTS_CFS) && !nssro)
		return false;

		/* If PCI error recovery process is happening, we cannot reset or
		* the recovery mechanism will surely fail.
		*/
		if (pci_channel_offline(to_pci_dev(dev->dev)))
		return false;

		return true;
		}

		@@ -1189,6 +1183,13 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)
		struct nvme_command cmd;
		u32 csts = readl(dev->bar + NVME_REG_CSTS);

		/* If PCI error recovery process is happening, we cannot reset or
		* the recovery mechanism will surely fail.
		*/
		mb();
		if (pci_channel_offline(to_pci_dev(dev->dev)))
		return BLK_EH_RESET_TIMER;

		/*
		* Reset immediately if the controller is failed
		*/

Admin message