Commit 6512391a authored Sep 06, 2016 by Colin Ian King Committed by Martin Schwidefsky Sep 06, 2016

s390/crypto: avoid returning garbage value



Static analysis with cppcheck detected that ret is not initialized
and hence garbage is potentially being returned in the case where
prng_data->ppnows.reseed_counter <= prng_reseed_limit.

Thanks to Martin Schwidefsky for spotting a mistake in my original
fix.

Fixes: 0177db01 ("s390/crypto: simplify return code handling")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

parent e68f1d4c

arch/s390/crypto/prng.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -434,7 +434,7 @@ static int prng_sha512_generate(u8 *buf, size_t nbytes)
		memcpy(prng_data->prev, buf, nbytes);
		}

		return ret;
		return nbytes;
		}

Admin message