net: dsa: b53: b53_arl_rw_op() needs to select IVL or SVL (64fec949) · Commits · 戴 / test

Flip the IVL_SVL_SELECT bit correctly based on the VLAN enable status, the default is to perform Shared VLAN learning instead of Individual learning. Fixes: ("net: dsa: b53: Implement ARL add/del/dump operations") Signed-off-by:

Florian Fainelli <f.fainelli@gmail.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/dsa/b53/b53_common.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1474,6 +1474,10 @@ static int b53_arl_rw_op(struct b53_device *dev, unsigned int op)
		reg \|= ARLTBL_RW;
		else
		reg &= ~ARLTBL_RW;
		if (dev->vlan_enabled)
		reg &= ~ARLTBL_IVL_SVL_SELECT;
		else
		reg \|= ARLTBL_IVL_SVL_SELECT;
		b53_write8(dev, B53_ARLIO_PAGE, B53_ARLTBL_RW_CTRL, reg);

		return b53_arl_op_wait(dev);

drivers/net/dsa/b53/b53_regs.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -292,6 +292,7 @@
		/* ARL Table Read/Write Register (8 bit) */
		#define B53_ARLTBL_RW_CTRL 0x00
		#define ARLTBL_RW BIT(0)
		#define ARLTBL_IVL_SVL_SELECT BIT(6)
		#define ARLTBL_START_DONE BIT(7)

		/* MAC Address Index Register (48 bit) */

Admin message