ice: Remove "2 BITS" comment (64f4b943) · Commits · 戴 / test

Some enums in ice_tx_desc_cmd_bits have a trailing /* 2 BITS */ comment, but the value has just one bit set (ex. ICE_TX_DESC_CMD_L4T_EOFT_SCTP has the value 0x200 (i.e. only bit 9 is set). This is confusing and misleading. So remove the comment. Signed-off-by:

Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> Tested-by:

Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:

Jeff Kirsher <jeffrey.t.kirsher@intel.com>

drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h

+6 −6

Original line number	Diff line number	Diff line
		@@ -342,12 +342,12 @@ enum ice_tx_desc_cmd_bits {
		ICE_TX_DESC_CMD_EOP = 0x0001,
		ICE_TX_DESC_CMD_RS = 0x0002,
		ICE_TX_DESC_CMD_IL2TAG1 = 0x0008,
		ICE_TX_DESC_CMD_IIPT_IPV6 = 0x0020, /* 2 BITS */
		ICE_TX_DESC_CMD_IIPT_IPV4 = 0x0040, /* 2 BITS */
		ICE_TX_DESC_CMD_IIPT_IPV4_CSUM = 0x0060, /* 2 BITS */
		ICE_TX_DESC_CMD_L4T_EOFT_TCP = 0x0100, /* 2 BITS */
		ICE_TX_DESC_CMD_L4T_EOFT_SCTP = 0x0200, /* 2 BITS */
		ICE_TX_DESC_CMD_L4T_EOFT_UDP = 0x0300, /* 2 BITS */
		ICE_TX_DESC_CMD_IIPT_IPV6 = 0x0020,
		ICE_TX_DESC_CMD_IIPT_IPV4 = 0x0040,
		ICE_TX_DESC_CMD_IIPT_IPV4_CSUM = 0x0060,
		ICE_TX_DESC_CMD_L4T_EOFT_TCP = 0x0100,
		ICE_TX_DESC_CMD_L4T_EOFT_SCTP = 0x0200,
		ICE_TX_DESC_CMD_L4T_EOFT_UDP = 0x0300,
		};

		#define ICE_TXD_QW1_OFFSET_S 16

Admin message