Commit 64e0cc38 authored Aug 05, 2006 by Linas Vepstas Committed by Linus Torvalds Aug 06, 2006

[PATCH] pSeries: hvsi char driver janitorial cleanup



A set of tty line discipline cleanup patches were introduced before the
dawn of time, in kernel version 2.4.21.  This patch performs that cleanup
for the hvsi driver.

The hvsi driver is used only on IBM pSeries PowerPC boxes.  The driver was
originally written by Hollis Blanchard, who has delegated maintainership to
me.  So this my first and maybe only patch in this official new role,
because this driver is otherwise bug-free :-)

Alan: "Actually its also a bug fix, tty->ldisc should be locked by refcounting
and the helpers do this for you."

Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 229395c9

drivers/char/hvsi.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -987,10 +987,7 @@ static void hvsi_write_worker(void *arg)
		start_j = 0;
		#endif /* DEBUG */
		wake_up_all(&hp->emptyq);
		if (test_bit(TTY_DO_WRITE_WAKEUP, &hp->tty->flags)
		&& hp->tty->ldisc.write_wakeup)
		hp->tty->ldisc.write_wakeup(hp->tty);
		wake_up_interruptible(&hp->tty->write_wait);
		tty_wakeup(hp->tty);
		}

		out:

Admin message