Commit 64d7b685 authored Sep 24, 2019 by Vlad Buslov Committed by Saeed Mahameed Oct 29, 2019

net/mlx5e: Only skip encap flows update when encap init failed



When encap entry initialization completes successfully e->compl_result is
set to positive value and not zero, like mlx5e_rep_update_flows() assumes
at the moment. Fix the conditional to only skip encap flows update when
e->compl_result < 0.

Fixes: 2a1f1768 ("net/mlx5e: Refactor neigh update for concurrent execution")
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent 5dfb6335

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -611,7 +611,7 @@ static void mlx5e_rep_update_flows(struct mlx5e_priv *priv,

		mutex_lock(&esw->offloads.encap_tbl_lock);
		encap_connected = !!(e->flags & MLX5_ENCAP_ENTRY_VALID);
		if (e->compl_result \|\| (encap_connected == neigh_connected &&
		if (e->compl_result < 0 \|\| (encap_connected == neigh_connected &&
		ether_addr_equal(e->h_dest, ha)))
		goto unlock;

Admin message