Unverified Commit 64bbacc5 authored Feb 18, 2020 by Takashi Iwai Committed by Mark Brown Feb 19, 2020

ASoC: intel: skl: Fix pin debug prints



skl_print_pins() loops over all given pins but it overwrites the text
at the very same position while increasing the returned length.
Fix this to show the all pin contents properly.

Fixes: d14700a0 ("ASoC: Intel: Skylake: Debugfs facility to dump module config")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20200218111737.14193-2-tiwai@suse.de


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 310006ca

sound/soc/intel/skylake/skl-debug.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -34,7 +34,7 @@ static ssize_t skl_print_pins(struct skl_module_pin m_pin, char buf,
		int i;
		ssize_t ret = 0;

		for (i = 0; i < max_pin; i++)
		for (i = 0; i < max_pin; i++) {
		ret += snprintf(buf + size, MOD_BUF - size,
		"%s %d\n\tModule %d\n\tInstance %d\n\t"
		"In-used %s\n\tType %s\n"
		@@ -45,6 +45,8 @@ static ssize_t skl_print_pins(struct skl_module_pin m_pin, char buf,
		m_pin[i].in_use ? "Used" : "Unused",
		m_pin[i].is_dynamic ? "Dynamic" : "Static",
		m_pin[i].pin_state, i);
		size += ret;
		}
		return ret;
		}

Admin message