Commit 64bafd2f authored Dec 12, 2018 by Darrick J. Wong

xfs: require both realtime inodes to mount

Since mkfs always formats the filesystem with the realtime bitmap and
summary inodes immediately after the root directory, we should expect
that both of them are present and loadable, even if there isn't a
realtime volume attached. There's no reason to skip this if rbmino ==
NULLFSINO; in fact, this causes an immediate crash if the there /is/ a
realtime volume and someone writes to it.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>

parent 355e3532

fs/xfs/xfs_rtalloc.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1206,13 +1206,11 @@ xfs_rtmount_inodes(
		xfs_sb_t *sbp;

		sbp = &mp->m_sb;
		if (sbp->sb_rbmino == NULLFSINO)
		return 0;
		error = xfs_iget(mp, NULL, sbp->sb_rbmino, 0, 0, &mp->m_rbmip);
		if (error)
		return error;
		ASSERT(mp->m_rbmip != NULL);
		ASSERT(sbp->sb_rsumino != NULLFSINO);

		error = xfs_iget(mp, NULL, sbp->sb_rsumino, 0, 0, &mp->m_rsumip);
		if (error) {
		xfs_irele(mp->m_rbmip);

Admin message