Commit 64b38bd1 authored Jan 31, 2020 by Thadeu Lima de Souza Cascardo Committed by Paolo Bonzini Feb 05, 2020

x86/kvm: do not setup pv tlb flush when not paravirtualized



kvm_setup_pv_tlb_flush will waste memory and print a misguiding message
when KVM paravirtualization is not available.

Intel SDM says that the when cpuid is used with EAX higher than the
maximum supported value for basic of extended function, the data for the
highest supported basic function will be returned.

So, in some systems, kvm_arch_para_features will return bogus data,
causing kvm_setup_pv_tlb_flush to detect support for pv tlb flush.

Testing for kvm_para_available will work as it checks for the hypervisor
signature.

Besides, when the "nopv" command line parameter is used, it should not
continue as well, as kvm_guest_init will no be called in that case.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 7df003c8

arch/x86/kernel/kvm.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -736,6 +736,9 @@ static __init int kvm_setup_pv_tlb_flush(void)
		{
		int cpu;

		if (!kvm_para_available() \|\| nopv)
		return 0;

		if (kvm_para_has_feature(KVM_FEATURE_PV_TLB_FLUSH) &&
		!kvm_para_has_hint(KVM_HINTS_REALTIME) &&
		kvm_para_has_feature(KVM_FEATURE_STEAL_TIME)) {

Admin message