Commit 64721094 authored Aug 15, 2016 by Wei Yongjun Committed by David S. Miller Aug 15, 2016

net: phy: Fix return value check in xgmiitorgmii_probe()



In case of error, the function of_parse_phandle() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cfaace26

drivers/net/phy/xilinx_gmii2rgmii.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -67,7 +67,7 @@ int xgmiitorgmii_probe(struct mdio_device *mdiodev)
		return -ENOMEM;

		phy_node = of_parse_phandle(np, "phy-handle", 0);
		if (IS_ERR(phy_node)) {
		if (!phy_node) {
		dev_err(dev, "Couldn't parse phy-handle\n");
		return -ENODEV;
		}

Admin message