Commit 6463a457 authored Jun 25, 2017 by Stephen Hemminger Committed by Greg Kroah-Hartman Jul 17, 2017

vmbus: re-enable channel tasklet



This problem shows up in 4.11 when netvsc driver is removed and reloaded.
The problem is that the channel is closed during module removal and the
tasklet for processing responses is disabled. When module is reloaded
the channel is reopened but the tasklet is marked as disabled.
The fix is to re-enable tasklet at the end of close which gets it back
to the initial state.

The issue is less urgent in 4.12 since network driver now uses NAPI
and not the tasklet; and other VMBUS devices are rarely unloaded/reloaded.

Fixes: dad72a1d ("vmbus: remove hv_event_tasklet_disable/enable")

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent eba9718e

drivers/hv/channel.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -606,6 +606,8 @@ static int vmbus_close_internal(struct vmbus_channel *channel)
		get_order(channel->ringbuffer_pagecount * PAGE_SIZE));

		out:
		/* re-enable tasklet for use on re-open */
		tasklet_enable(&channel->callback_event);
		return ret;
		}

Admin message