cfg80211: Fix regulatory check for 60GHz band frequencies (64629b9d) · Commits · 戴 / test

The current regulatory code on cfg80211 performs a check to see if a regulatory rule belongs to an IEEE band so that if a Country IE is received and no rules are specified for a band (which is allowed by IEEE) those bands are left intact. The current band check assumes a rule is bound to a band if the rule's start or end frequency is less than 2 GHz apart from the center of frequency being inspected. In order to support 60 GHz for 802.11ad we need to increase this to account for the channel spacing of 2160 MHz whereby a channel somewhere in the middle of a regulatory rule may be more than 2 GHz apart from either the beginning or end of the frequency rule. Without a fix for this even though channels 1-3 are allowed world wide on the rule (57240 - 63720 @ 2160), channel 2 at 60480 MHz will end up getting disabled given that it is 3240 MHz from both the frequency rule start and end frequency. Fix this by using 2 GHz separation assumption for the 2.4 and 5 GHz bands but for 60 GHz use a 10 GHz separation before assuming a rule is not part of the band. Since we have no 802.11ad drivers yet merged this change has no impact to existing Linux upstream device drivers. Signed-off-by:

Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> Acked-by:

Luis R. Rodriguez <mcgrof@do-not-panic.com> Signed-off-by:

Johannes Berg <johannes.berg@intel.com>

net/wireless/reg.c

+14 −5

Original line number	Diff line number	Diff line
		@@ -504,9 +504,11 @@ static bool reg_does_bw_fit(const struct ieee80211_freq_range *freq_range,
		*
		* This lets us know if a specific frequency rule is or is not relevant to
		* a specific frequency's band. Bands are device specific and artificial
		* definitions (the "2.4 GHz band" and the "5 GHz band"), however it is
		* safe for now to assume that a frequency rule should not be part of a
		* frequency's band if the start freq or end freq are off by more than 2 GHz.
		* definitions (the "2.4 GHz band", the "5 GHz band" and the "60GHz band"),
		* however it is safe for now to assume that a frequency rule should not be
		* part of a frequency's band if the start freq or end freq are off by more
		* than 2 GHz for the 2.4 and 5 GHz bands, and by more than 10 GHz for the
		* 60 GHz band.
		* This resolution can be lowered and should be considered as we add
		* regulatory rule support for other "bands".
		**/
		@@ -514,9 +516,16 @@ static bool freq_in_rule_band(const struct ieee80211_freq_range *freq_range,
		u32 freq_khz)
		{
		#define ONE_GHZ_IN_KHZ 1000000
		if (abs(freq_khz - freq_range->start_freq_khz) <= (2 * ONE_GHZ_IN_KHZ))
		/*
		* From 802.11ad: directional multi-gigabit (DMG):
		* Pertaining to operation in a frequency band containing a channel
		* with the Channel starting frequency above 45 GHz.
		*/
		u32 limit = freq_khz > 45 * ONE_GHZ_IN_KHZ ?
		10 * ONE_GHZ_IN_KHZ : 2 * ONE_GHZ_IN_KHZ;
		if (abs(freq_khz - freq_range->start_freq_khz) <= limit)
		return true;
		if (abs(freq_khz - freq_range->end_freq_khz) <= (2 * ONE_GHZ_IN_KHZ))
		if (abs(freq_khz - freq_range->end_freq_khz) <= limit)
		return true;
		return false;
		#undef ONE_GHZ_IN_KHZ

Admin message