HID: wacom: Correct button numbering 2nd-gen Intuos Pro over Bluetooth (6441fc78) · Commits · 戴 / test

The button numbering of the 2nd-gen Intuos Pro is not consistent between the USB and Bluetooth interfaces. Over USB, the HID_GENERIC codepath enumerates the eight ExpressKeys first (BTN_0 - BTN_7) followed by the center modeswitch button (BTN_8). The Bluetooth codepath, however, has the center modeswitch button as BTN_0 and the the eight ExpressKeys as BTN_1 - BTN_8. To ensure userspace button mappings do not change depending on how the tablet is connected, modify the Bluetooth codepath to report buttons in the same order as USB. To ensure the mode switch LED continues to toggle in response to the mode switch button, the `wacom_is_led_toggled` function also requires a small update. Link: https://github.com/linuxwacom/input-wacom/pull/79 Fixes: ("HID: wacom: Support 2nd-gen Intuos Pro's Bluetooth classic interface") Cc: <stable@vger.kernel.org> # 4.11+ Signed-off-by:

Jason Gerecke <jason.gerecke@wacom.com> Reviewed-by:

Aaron Skomra <aaron.skomra@wacom.com> Signed-off-by:

Benjamin Tissoires <benjamin.tissoires@redhat.com>

drivers/hid/wacom_wac.c

+7 −4

Original line number	Diff line number	Diff line
		@@ -1383,7 +1383,7 @@ static void wacom_intuos_pro2_bt_pad(struct wacom_wac *wacom)
		struct input_dev *pad_input = wacom->pad_input;
		unsigned char *data = wacom->data;

		int buttons = (data[282] << 1) \| ((data[281] >> 6) & 0x01);
		int buttons = data[282] \| ((data[281] & 0x40) << 2);
		int ring = data[285] & 0x7F;
		bool ringstatus = data[285] & 0x80;
		bool prox = buttons \|\| ringstatus;
		@@ -3832,7 +3832,7 @@ static void wacom_24hd_update_leds(struct wacom *wacom, int mask, int group)
		static bool wacom_is_led_toggled(struct wacom *wacom, int button_count,
		int mask, int group)
		{
		int button_per_group;
		int group_button;

		/*
		* 21UX2 has LED group 1 to the left and LED group 0
		@@ -3842,9 +3842,12 @@ static bool wacom_is_led_toggled(struct wacom *wacom, int button_count,
		if (wacom->wacom_wac.features.type == WACOM_21UX2)
		group = 1 - group;

		button_per_group = button_count/wacom->led.count;
		group_button = group * (button_count/wacom->led.count);

		return mask & (1 << (group * button_per_group));
		if (wacom->wacom_wac.features.type == INTUOSP2_BT)
		group_button = 8;

		return mask & (1 << group_button);
		}

		static void wacom_update_led(struct wacom *wacom, int button_count, int mask,

Admin message