Commit 6431a7e3 authored Sep 03, 2017 by Christophe Jaillet Committed by Mark Brown Sep 04, 2017

ASoC: samsung: i2s: Fix error handling path in i2s_set_sysclk()



If 'clk_prepare_enable()' fails, we must 'put' the corresponding clock.
Othewise, there is a resource leak.

Fixes: f5c97c7b ("ASoC: samsung: i2s: Handle return value of clk_prepare_enable.")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 1107a293

sound/soc/samsung/i2s.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -552,8 +552,11 @@ static int i2s_set_sysclk(struct snd_soc_dai *dai,
		}

		ret = clk_prepare_enable(i2s->op_clk);
		if (ret)
		if (ret) {
		clk_put(i2s->op_clk);
		i2s->op_clk = NULL;
		goto err;
		}
		i2s->rclk_srcrate = clk_get_rate(i2s->op_clk);

		/* Over-ride the other's */

Admin message