Commit 642dbc39 authored by Vincent Guittot's avatar Vincent Guittot Committed by Ingo Molnar
Browse files

sched: Fix wrong rq's runnable_avg update with rt tasks 



The current update of the rq's load can be erroneous when RT
tasks are involved.

The update of the load of a rq that becomes idle, is done only
if the avg_idle is less than sysctl_sched_migration_cost. If RT
tasks and short idle duration alternate, the runnable_avg will
not be updated correctly and the time will be accounted as idle
time when a CFS task wakes up.

A new idle_enter function is called when the next task is the
idle function so the elapsed time will be accounted as run time
in the load of the rq, whatever the average idle time is. The
function update_rq_runnable_avg is removed from idle_balance.

When a RT task is scheduled on an idle CPU, the update of the
rq's load is not done when the rq exit idle state because CFS's
functions are not called. Then, the idle_balance, which is
called just before entering the idle function, updates the rq's
load and makes the assumption that the elapsed time since the
last update, was only running time.

As a consequence, the rq's load of a CPU that only runs a
periodic RT task, is close to LOAD_AVG_MAX whatever the running
duration of the RT task is.

A new idle_exit function is called when the prev task is the
idle function so the elapsed time will be accounted as idle time
in the rq's load.

Signed-off-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Acked-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Cc: linaro-kernel@lists.linaro.org
Cc: peterz@infradead.org
Cc: pjt@google.com
Cc: fweisbec@gmail.com
Cc: efault@gmx.de
Link: http://lkml.kernel.org/r/1366302867-5055-1-git-send-email-vincent.guittot@linaro.org


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 9b89f6ba

kernel/sched/fair.c

+21 −2
Original line number Diff line number Diff line
@@ -1563,6 +1563,27 @@ static inline void dequeue_entity_load_avg(struct cfs_rq *cfs_rq, 
		se->avg.decay_count = atomic64_read(&cfs_rq->decay_counter);

	} /* migrations, e.g. sleep=0 leave decay_count == 0 */

}



/*

 * Update the rq's load with the elapsed running time before entering

 * idle. if the last scheduled task is not a CFS task, idle_enter will

 * be the only way to update the runnable statistic.

 */

void idle_enter_fair(struct rq *this_rq)

{

	update_rq_runnable_avg(this_rq, 1);

}



/*

 * Update the rq's load with the elapsed idle time before a task is

 * scheduled. if the newly scheduled task is not a CFS task, idle_exit will

 * be the only way to update the runnable statistic.

 */

void idle_exit_fair(struct rq *this_rq)

{

	update_rq_runnable_avg(this_rq, 0);

}



#else

static inline void update_entity_load_avg(struct sched_entity *se,

					  int update_cfs_rq) {}
@@ -5217,8 +5238,6 @@ void idle_balance(int this_cpu, struct rq *this_rq) 
	if (this_rq->avg_idle < sysctl_sched_migration_cost)

		return;



	update_rq_runnable_avg(this_rq, 1);



	/*

	 * Drop the rq->lock, but keep IRQ/preempt disabled.

	 */

kernel/sched/idle_task.c

+16 −0
Original line number Diff line number Diff line
@@ -13,6 +13,16 @@ select_task_rq_idle(struct task_struct *p, int sd_flag, int flags) 
{

	return task_cpu(p); /* IDLE tasks as never migrated */

}



static void pre_schedule_idle(struct rq *rq, struct task_struct *prev)

{

	idle_exit_fair(rq);

}



static void post_schedule_idle(struct rq *rq)

{

	idle_enter_fair(rq);

}

#endif /* CONFIG_SMP */

/*

 * Idle tasks are unconditionally rescheduled:
@@ -25,6 +35,10 @@ static void check_preempt_curr_idle(struct rq *rq, struct task_struct *p, int fl 
static struct task_struct *pick_next_task_idle(struct rq *rq)

{

	schedstat_inc(rq, sched_goidle);

#ifdef CONFIG_SMP

	/* Trigger the post schedule to do an idle_enter for CFS */

	rq->post_schedule = 1;

#endif

	return rq->idle;

}
@@ -86,6 +100,8 @@ const struct sched_class idle_sched_class = { 


#ifdef CONFIG_SMP

	.select_task_rq		= select_task_rq_idle,

	.pre_schedule		= pre_schedule_idle,

	.post_schedule		= post_schedule_idle,

#endif



	.set_curr_task          = set_curr_task_idle,

kernel/sched/sched.h

+12 −0
Original line number Diff line number Diff line
@@ -1024,6 +1024,18 @@ extern void update_group_power(struct sched_domain *sd, int cpu); 
extern void trigger_load_balance(struct rq *rq, int cpu);

extern void idle_balance(int this_cpu, struct rq *this_rq);



/*

 * Only depends on SMP, FAIR_GROUP_SCHED may be removed when runnable_avg

 * becomes useful in lb

 */

#if defined(CONFIG_FAIR_GROUP_SCHED)

extern void idle_enter_fair(struct rq *this_rq);

extern void idle_exit_fair(struct rq *this_rq);

#else

static inline void idle_enter_fair(struct rq *this_rq) {}

static inline void idle_exit_fair(struct rq *this_rq) {}

#endif



#else	/* CONFIG_SMP */



static inline void idle_balance(int cpu, struct rq *rq)

CRA Git | Maintained and supported by SUSTech CRA and CCSE