x86/build: Declutter the build output (642d94cf) · Commits · 戴 / test

We have some really ancient debug printouts in the x86 boot image build code: Setup is 14108 bytes (padded to 14336 bytes). System is 8802 kB CRC 27e909d4 None of these ever helped debug any sort of breakage that I know of, and they clutter the build output. Remove them - if anyone needs the see the various interim stages of this to debug an obscure bug, they can add these printfs and more. We still keep this one: Kernel: arch/x86/boot/bzImage is ready (#19) As a sentimental leftover, plus the '#19' build count tag is mildly useful. Signed-off-by:

Ingo Molnar <mingo@kernel.org> Cc: linux-kernel@vger.kernel.org Cc: x86@kernel.org

arch/x86/boot/tools/build.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -416,8 +416,6 @@ int main(int argc, char ** argv)
		/* Set the default root device */
		put_unaligned_le16(DEFAULT_ROOT_DEV, &buf[508]);

		printf("Setup is %d bytes (padded to %d bytes).\n", c, i);

		/* Open and stat the kernel file */
		fd = open(argv[2], O_RDONLY);
		if (fd < 0)
		@@ -425,7 +423,6 @@ int main(int argc, char ** argv)
		if (fstat(fd, &sb))
		die("Unable to stat `%s': %m", argv[2]);
		sz = sb.st_size;
		printf("System is %d kB\n", (sz+1023)/1024);
		kernel = mmap(NULL, sz, PROT_READ, MAP_SHARED, fd, 0);
		if (kernel == MAP_FAILED)
		die("Unable to mmap '%s': %m", argv[2]);
		@@ -488,7 +485,6 @@ int main(int argc, char ** argv)
		}

		/* Write the CRC */
		printf("CRC %x\n", crc);
		put_unaligned_le32(crc, buf);
		if (fwrite(buf, 1, 4, dest) != 4)
		die("Writing CRC failed");

Admin message