Commit 642ac6c0 authored Aug 10, 2015 by Shraddha Barke Committed by Greg Kroah-Hartman Aug 14, 2015

Staging: wilc1000: Remove null check before kfree



kfree on NULL pointer is a no-op.

This patch uses the following semantic patch to find such an instance
where NULL check is present before kfree.

// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>smpl>

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 772a6e1f

drivers/staging/wilc1000/linux_wlan.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2338,7 +2338,6 @@ int mac_ioctl(struct net_device ndev, struct ifreq req, int cmd)

		done:

		if (buff != NULL)
		kfree(buff);

		return s32Error;

Admin message