Commit 6429ccdd authored by Gilad Ben-Yossef's avatar Gilad Ben-Yossef Committed by Herbert Xu
Browse files

crypto: ccree - remove ancient TODO remarks 



Remove left over ancient and now misleading TODO remarks.

Signed-off-by: default avatarGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 8b9d6e98

drivers/crypto/ccree/cc_aead.c

+0 −1
Original line number Diff line number Diff line
@@ -1990,7 +1990,6 @@ static int cc_proc_aead(struct aead_request *req, 
	/* Load MLLI tables to SRAM if necessary */

	cc_mlli_to_sram(req, desc, &seq_len);



	/*TODO: move seq len by reference */

	switch (ctx->auth_mode) {

	case DRV_HASH_SHA1:

	case DRV_HASH_SHA256:

drivers/crypto/ccree/cc_buffer_mgr.c

+0 −2
Original line number Diff line number Diff line
@@ -606,7 +606,6 @@ static int cc_aead_chain_iv(struct cc_drvdata *drvdata, 


	dev_dbg(dev, "Mapped iv %u B at va=%pK to dma=%pad\n",

		hw_iv_size, req->iv, &areq_ctx->gen_ctx.iv_dma_addr);

	// TODO: what about CTR?? ask Ron

	if (do_chain && areq_ctx->plaintext_authenticate_only) {

		struct crypto_aead *tfm = crypto_aead_reqtfm(req);

		unsigned int iv_size_to_authenc = crypto_aead_ivsize(tfm);
@@ -1225,7 +1224,6 @@ int cc_map_hash_request_final(struct cc_drvdata *drvdata, void *ctx, 
		return 0;

	}



	/*TODO: copy data in case that buffer is enough for operation */

	/* map the previous buffer */

	if (*curr_buff_cnt) {

		rc = cc_set_hash_buf(dev, areq_ctx, curr_buff, *curr_buff_cnt,

drivers/crypto/ccree/cc_cipher.c

+0 −1
Original line number Diff line number Diff line
@@ -859,7 +859,6 @@ static int cc_cipher_process(struct skcipher_request *req, 


	/* STAT_PHASE_0: Init and sanity checks */



	/* TODO: check data length according to mode */

	if (validate_data_size(ctx_p, nbytes)) {

		dev_dbg(dev, "Unsupported data size %d.\n", nbytes);

		rc = -EINVAL;

drivers/crypto/ccree/cc_hash.c

+0 −3
Original line number Diff line number Diff line
@@ -349,7 +349,6 @@ static int cc_fin_result(struct cc_hw_desc *desc, struct ahash_request *req, 
	/* Get final MAC result */

	hw_desc_init(&desc[idx]);

	set_hash_cipher_mode(&desc[idx], ctx->hw_mode, ctx->hash_mode);

	/* TODO */

	set_dout_dlli(&desc[idx], state->digest_result_dma_addr, digestsize,

		      NS_BIT, 1);

	set_queue_last_ind(ctx->drvdata, &desc[idx]);
@@ -1319,7 +1318,6 @@ static int cc_mac_final(struct ahash_request *req) 


	/* Get final MAC result */

	hw_desc_init(&desc[idx]);

	/* TODO */

	set_dout_dlli(&desc[idx], state->digest_result_dma_addr,

		      digestsize, NS_BIT, 1);

	set_queue_last_ind(ctx->drvdata, &desc[idx]);
@@ -1401,7 +1399,6 @@ static int cc_mac_finup(struct ahash_request *req) 


	/* Get final MAC result */

	hw_desc_init(&desc[idx]);

	/* TODO */

	set_dout_dlli(&desc[idx], state->digest_result_dma_addr,

		      digestsize, NS_BIT, 1);

	set_queue_last_ind(ctx->drvdata, &desc[idx]);

drivers/crypto/ccree/cc_request_mgr.c

+0 −1
Original line number Diff line number Diff line
@@ -296,7 +296,6 @@ static void cc_do_send_request(struct cc_drvdata *drvdata, 
	req_mgr_h->req_queue[req_mgr_h->req_queue_head] = *cc_req;

	req_mgr_h->req_queue_head = (req_mgr_h->req_queue_head + 1) &

				    (MAX_REQUEST_QUEUE_SIZE - 1);

	/* TODO: Use circ_buf.h ? */



	dev_dbg(dev, "Enqueue request head=%u\n", req_mgr_h->req_queue_head);

CRA Git | Maintained and supported by SUSTech CRA and CCSE