Commit 641e0efd authored Dec 17, 2019 by Quinn Tran Committed by Martin K. Petersen Dec 21, 2019

scsi: qla2xxx: Fix mtcp dump collection failure

MTCP dump failed due to MB Reg 10 was picking garbage data from stack
memory.

Fixes: 81178772 ("[SCSI] qla2xxx: Implemetation of mctp.")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20191217220617.28084-14-hmadhani@marvell.com


Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent e1217dc3

drivers/scsi/qla2xxx/qla_mbx.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -6152,9 +6152,8 @@ qla2x00_dump_mctp_data(scsi_qla_host_t *vha, dma_addr_t req_dma, uint32_t addr,
		mcp->mb[7] = LSW(MSD(req_dma));
		mcp->mb[8] = MSW(addr);
		/* Setting RAM ID to valid */
		mcp->mb[10] \|= BIT_7;
		/* For MCTP RAM ID is 0x40 */
		mcp->mb[10] \|= 0x40;
		mcp->mb[10] = BIT_7 \| 0x40;

		mcp->out_mb \|= MBX_10\|MBX_8\|MBX_7\|MBX_6\|MBX_5\|MBX_4\|MBX_3\|MBX_2\|MBX_1\|
		MBX_0;

Admin message