Commit 640a8af5 authored by Alexander Duyck's avatar Alexander Duyck Committed by Jeff Kirsher
Browse files

i40evf: Reorder configure_clsflower to avoid deadlock on error 



While doing some code review I noticed that we can get into a state where
we exit with the "IN_CRITICAL_TASK" bit set while notifying the PF of
flower filters. This patch is meant to address that plus tweak the ordering
of the while loop waiting on it slightly so that we don't wait an extra
period after we have failed for the last time.

Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent e3c72f3d

drivers/net/ethernet/intel/i40evf/i40evf_main.c

+11 −12
Original line number Diff line number Diff line
@@ -2791,14 +2791,7 @@ static int i40evf_configure_clsflower(struct i40evf_adapter *adapter, 
{

	int tc = tc_classid_to_hwtc(adapter->netdev, cls_flower->classid);

	struct i40evf_cloud_filter *filter = NULL;

	int err = 0, count = 50;



	while (test_and_set_bit(__I40EVF_IN_CRITICAL_TASK,

				&adapter->crit_section)) {

		udelay(1);

		if (--count == 0)

			return -EINVAL;

	}

	int err = -EINVAL, count = 50;



	if (tc < 0) {

		dev_err(&adapter->pdev->dev, "Invalid traffic class\n");
@@ -2806,10 +2799,16 @@ static int i40evf_configure_clsflower(struct i40evf_adapter *adapter, 
	}



	filter = kzalloc(sizeof(*filter), GFP_KERNEL);

	if (!filter) {

		err = -ENOMEM;

		goto clearout;

	if (!filter)

		return -ENOMEM;



	while (test_and_set_bit(__I40EVF_IN_CRITICAL_TASK,

				&adapter->crit_section)) {

		if (--count == 0)

			goto err;

		udelay(1);

	}



	filter->cookie = cls_flower->cookie;



	/* set the mask to all zeroes to begin with */
@@ -2834,7 +2833,7 @@ static int i40evf_configure_clsflower(struct i40evf_adapter *adapter, 
err:

	if (err)

		kfree(filter);

clearout:



	clear_bit(__I40EVF_IN_CRITICAL_TASK, &adapter->crit_section);

	return err;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE