Commit 6405fe21 authored May 27, 2020 by Christian Gromm Committed by Greg Kroah-Hartman May 27, 2020

staging: most: usb: don't use error path to exit function on success



This patch makes it transparent whether the function is exiting
with an error or successful.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/1590570387-27069-7-git-send-email-christian.gromm@microchip.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8bf56cfa

drivers/staging/most/usb/usb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -519,13 +519,13 @@ static int hdm_enqueue(struct most_interface *iface, int channel,
		"URB submit failed with error %d.\n", retval);
		goto err_unanchor_urb;
		}
		goto unlock_io_mutex;
		mutex_unlock(&mdev->io_mutex);
		return 0;

		err_unanchor_urb:
		usb_unanchor_urb(urb);
		err_free_urb:
		usb_free_urb(urb);
		unlock_io_mutex:
		mutex_unlock(&mdev->io_mutex);
		return retval;
		}

Admin message