Commit 63fa471d authored Mar 27, 2012 by David Miller Committed by Arnaldo Carvalho de Melo Apr 05, 2012

perf hists: Catch and handle out-of-date hist entry maps.



When a process exec()'s, all the maps are retired, but we keep the hist
entries around which hold references to those outdated maps.

If the same library gets mapped in for which we have hist entries, a new
map will be created.  But when we take a perf entry hit within that map,
we'll find the existing hist entry with the older map.

This causes symbol translations to be done incorrectly.  For example,
the perf entry processing will lookup the correct uptodate map entry and
use that to calculate the symbol and DSO relative address.  But later
when we update the histogram we'll translate the address using the
outdated map file instead leading to conditions such as out-of-range
offsets in symbol__inc_addr_samples().

Therefore, update the map of the hist_entry dynamically at lookup/
creation time.

Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: stable@kernel.org
Link: http://lkml.kernel.org/r/20120327.031418.1220315351537060808.davem@davemloft.net


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 8b84a568

tools/perf/util/hist.c

+12 −0

Original line number	Diff line number	Diff line
		@@ -256,6 +256,18 @@ static struct hist_entry add_hist_entry(struct hists hists,
		if (!cmp) {
		he->period += period;
		++he->nr_events;

		/* If the map of an existing hist_entry has
		* become out-of-date due to an exec() or
		* similar, update it. Otherwise we will
		* mis-adjust symbol addresses when computing
		* the history counter to increment.
		*/
		if (he->ms.map != entry->ms.map) {
		he->ms.map = entry->ms.map;
		if (he->ms.map)
		he->ms.map->referenced = true;
		}
		goto out;
		}

Admin message