Commit 63f55fce authored Apr 24, 2019 by Jiada Wang Committed by Eduardo Valentin May 14, 2019

thermal: rcar_gen3_thermal: disable interrupt in .remove



Currently IRQ remains enabled after .remove, later if device is probed,
IRQ is requested before .thermal_init, this may cause IRQ function be
called before device is initialized.

this patch disables interrupt in .remove, to ensure irq function
only be called after device is fully initialized.

Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>

parent 2c0928c9

drivers/thermal/rcar_gen3_thermal.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -307,6 +307,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids);
		static int rcar_gen3_thermal_remove(struct platform_device *pdev)
		{
		struct device *dev = &pdev->dev;
		struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev);

		rcar_thermal_irq_set(priv, false);

		pm_runtime_put(dev);
		pm_runtime_disable(dev);

Admin message