Commit 63ea641f authored Sep 29, 2017 by Colin Ian King Committed by Doug Ledford Oct 04, 2017

RDMA/hns: return 0 rather than return a garbage status value



For the case where hr_qp->state == IB_QPS_RESET, an uninitialized
value in ret is being returned by function hns_roce_v2_query_qp.
Fix this by setting ret to 0 for this specific return condition.

Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 988e175b

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2807,6 +2807,7 @@ static int hns_roce_v2_query_qp(struct ib_qp ibqp, struct ib_qp_attr qp_attr,

		if (hr_qp->state == IB_QPS_RESET) {
		qp_attr->qp_state = IB_QPS_RESET;
		ret = 0;
		goto done;
		}

Admin message