Commit 63dca8d5 authored Jul 30, 2012 by Vivek Goyal Committed by Linus Torvalds Jul 30, 2012

kdump: append newline to the last lien of vmcoreinfo note



The last line of vmcoreinfo note does not end with \n.  Parsing all the
lines in note becomes easier if all lines end with \n instead of trying to
special case the last line.

I know at least one tool, vmcore-dmesg in kexec-tools tree which made the
assumption that all lines end with \n.  I think it is a good idea to fix
it.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Atsushi Kumagai <kumagai-atsushi@mxc.nes.nec.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent f19b9f74

kernel/kexec.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1424,7 +1424,7 @@ static void update_vmcoreinfo_note(void)

		void crash_save_vmcoreinfo(void)
		{
		vmcoreinfo_append_str("CRASHTIME=%ld", get_seconds());
		vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds());
		update_vmcoreinfo_note();
		}

Admin message