Commit 63d71450 authored Sep 01, 2017 by Naohiro Aota Committed by David Sterba Sep 26, 2017

btrfs: clear ordered flag on cleaning up ordered extents



Commit 52427260 ("btrfs: Handle delalloc error correctly to avoid
ordered extent hang") introduced btrfs_cleanup_ordered_extents() to cleanup
submitted ordered extents. However, it does not clear the ordered bit
(Private2) of corresponding pages. Thus, the following BUG occurs from
free_pages_check_bad() (on btrfs/125 with nospace_cache).

BUG: Bad page state in process btrfs  pfn:3fa787
page:ffffdf2acfe9e1c0 count:0 mapcount:0 mapping:          (null) index:0xd
flags: 0x8000000000002008(uptodate|private_2)
raw: 8000000000002008 0000000000000000 000000000000000d 00000000ffffffff
raw: ffffdf2acf5c1b20 ffffb443802238b0 0000000000000000 0000000000000000
page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) set
bad because of flags: 0x2000(private_2)

This patch clears the flag same as other places calling
btrfs_dec_test_ordered_pending() for every page in the specified range.

Fixes: 52427260 ("btrfs: Handle delalloc error correctly to avoid ordered extent hang")
Cc: <stable@vger.kernel.org> # 4.12
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: Qu Wenruo <quwenruo.btrfs@gmx.com>
Reviewed-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent bea7eafd

fs/btrfs/inode.c

+12 −0

Original line number	Diff line number	Diff line
		@@ -135,6 +135,18 @@ static inline void btrfs_cleanup_ordered_extents(struct inode *inode,
		const u64 offset,
		const u64 bytes)
		{
		unsigned long index = offset >> PAGE_SHIFT;
		unsigned long end_index = (offset + bytes - 1) >> PAGE_SHIFT;
		struct page *page;

		while (index <= end_index) {
		page = find_get_page(inode->i_mapping, index);
		index++;
		if (!page)
		continue;
		ClearPagePrivate2(page);
		put_page(page);
		}
		return __endio_write_update_ordered(inode, offset + PAGE_SIZE,
		bytes - PAGE_SIZE, false);
		}

Admin message