Commit 63c17fb8 authored Feb 12, 2016 by Dave Hansen Committed by Ingo Molnar Feb 18, 2016

mm/core, x86/mm/pkeys: Store protection bits in high VMA flags



vma->vm_flags is an 'unsigned long', so has space for 32 flags
on 32-bit architectures.  The high 32 bits are unused on 64-bit
platforms.  We've steered away from using the unused high VMA
bits for things because we would have difficulty supporting it
on 32-bit.

Protection Keys are not available in 32-bit mode, so there is
no concern about supporting this feature in 32-bit mode or on
32-bit CPUs.

This patch carves out 4 bits from the high half of
vma->vm_flags and allows architectures to set config option
to make them available.

Sparse complains about these constants unless we explicitly
call them "UL".

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Hansen <dave@sr71.net>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Sasha Levin <sasha.levin@oracle.com>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Vladimir Davydov <vdavydov@parallels.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Xie XiuQi <xiexiuqi@huawei.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Link: http://lkml.kernel.org/r/20160212210208.81AF00D5@viggo.jf.intel.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent b3ecd515

arch/x86/Kconfig

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -155,6 +155,7 @@ config X86
	select VIRT_TO_BUS		select VIRT_TO_BUS
	select X86_DEV_DMA_OPS if X86_64		select X86_DEV_DMA_OPS if X86_64
	select X86_FEATURE_NAMES if PROC_FS		select X86_FEATURE_NAMES if PROC_FS
			select ARCH_USES_HIGH_VMA_FLAGS if X86_INTEL_MEMORY_PROTECTION_KEYS

	config INSTRUCTION_DECODER		config INSTRUCTION_DECODER
	def_bool y		def_bool y

include/linux/mm.h

+11 −0

Original line number	Original line	Diff line number	Diff line
	@@ -170,6 +170,17 @@ extern unsigned int kobjsize(const void *objp);
	#define VM_NOHUGEPAGE 0x40000000 /* MADV_NOHUGEPAGE marked this vma */		#define VM_NOHUGEPAGE 0x40000000 /* MADV_NOHUGEPAGE marked this vma */
	#define VM_MERGEABLE 0x80000000 /* KSM may merge identical pages */		#define VM_MERGEABLE 0x80000000 /* KSM may merge identical pages */

			#ifdef CONFIG_ARCH_USES_HIGH_VMA_FLAGS
			#define VM_HIGH_ARCH_BIT_0 32 /* bit only usable on 64-bit architectures */
			#define VM_HIGH_ARCH_BIT_1 33 /* bit only usable on 64-bit architectures */
			#define VM_HIGH_ARCH_BIT_2 34 /* bit only usable on 64-bit architectures */
			#define VM_HIGH_ARCH_BIT_3 35 /* bit only usable on 64-bit architectures */
			#define VM_HIGH_ARCH_0 BIT(VM_HIGH_ARCH_BIT_0)
			#define VM_HIGH_ARCH_1 BIT(VM_HIGH_ARCH_BIT_1)
			#define VM_HIGH_ARCH_2 BIT(VM_HIGH_ARCH_BIT_2)
			#define VM_HIGH_ARCH_3 BIT(VM_HIGH_ARCH_BIT_3)
			#endif /* CONFIG_ARCH_USES_HIGH_VMA_FLAGS */

	#if defined(CONFIG_X86)		#if defined(CONFIG_X86)
	# define VM_PAT VM_ARCH_1 /* PAT reserves whole VMA at once (x86) */		# define VM_PAT VM_ARCH_1 /* PAT reserves whole VMA at once (x86) */
	#elif defined(CONFIG_PPC)		#elif defined(CONFIG_PPC)

mm/Kconfig

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -669,3 +669,6 @@ config ZONE_DEVICE

	config FRAME_VECTOR		config FRAME_VECTOR
	bool		bool

			config ARCH_USES_HIGH_VMA_FLAGS
			bool

Admin message