Commit 63a9c3ed authored by Jeeeun Evans's avatar Jeeeun Evans Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: Fix boolinit.cocci warnings 



This patch removes unnecessary comparisons to bool.

Issue found by coccinelle:
drivers/staging/rtl8723bs/core/rtw_ap.c:2159:5-11: WARNING: Comparison to bool
drivers/staging/rtl8723bs/core/rtw_cmd.c:1741:7-17: WARNING: Comparison to bool
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:360:5-15: WARNING: Comparison to bool
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:360:28-39: WARNING: Comparison to bool
drivers/staging/rtl8723bs/core/rtw_mlme.c:1675:6-10: WARNING: Comparison to bool
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:6766:8-21: WARNING: Comparison to bool
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:181:5-40: WARNING: Comparison to bool
drivers/staging/rtl8723bs/core/rtw_wlan_util.c:748:14-42: WARNING: Comparison to bool
drivers/staging/rtl8723bs/core/rtw_xmit.c:2429:15-47: WARNING: Comparison to bool
drivers/staging/rtl8723bs/core/rtw_xmit.c:2458:7-17: WARNING: Comparison to bool
drivers/staging/rtl8723bs/core/rtw_xmit.c:2524:8-18: WARNING: Comparison to bool
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1653:13-36: WARNING: Comparison to bool

Signed-off-by: default avatarJeeeun Evans <jeeeunevans@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 37d13c28

drivers/staging/rtl8723bs/core/rtw_ap.c

+1 −1
Original line number Diff line number Diff line
@@ -2156,7 +2156,7 @@ u8 ap_free_sta( 
	if (!psta)

		return beacon_updated;



	if (active == true) {

	if (active) {

		/* tear down Rx AMPDU */

		send_delba(padapter, 0, psta->hwaddr);/*  recipient */

drivers/staging/rtl8723bs/core/rtw_cmd.c

+1 −1
Original line number Diff line number Diff line
@@ -1738,7 +1738,7 @@ static void rtw_chk_hi_queue_hdl(struct adapter *padapter) 
			pstapriv->tim_bitmap &= ~BIT(0);

			pstapriv->sta_dz_bitmap &= ~BIT(0);



			if (update_tim == true)

			if (update_tim)

				update_beacon(padapter, _TIM_IE_, NULL, true);

		} else {/* re check again */

			rtw_chk_hi_queue_cmd(padapter);

drivers/staging/rtl8723bs/core/rtw_ioctl_set.c

+1 −1
Original line number Diff line number Diff line
@@ -357,7 +357,7 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u8 *bssid, struct ndis_802_1 
	if (!bssid || rtw_validate_bssid(bssid) == false)

		bssid_valid = false;



	if (ssid_valid == false && bssid_valid == false) {

	if (!ssid_valid && !bssid_valid) {

		DBG_871X(FUNC_ADPT_FMT" ssid:%p, ssid_valid:%d, bssid:%p, bssid_valid:%d\n",

			FUNC_ADPT_ARG(padapter), ssid, ssid_valid, bssid, bssid_valid);

		status = _FAIL;

drivers/staging/rtl8723bs/core/rtw_mlme.c

+1 −1
Original line number Diff line number Diff line
@@ -1672,7 +1672,7 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf) 
			roam_target = pmlmepriv->roam_network;

		}



		if (roam == true) {

		if (roam) {

			if (rtw_to_roam(adapter) > 0)

				rtw_dec_to_roam(adapter); /* this stadel_event is caused by roaming, decrease to_roam */

			else if (rtw_to_roam(adapter) == 0)

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

+1 −1
Original line number Diff line number Diff line
@@ -6763,7 +6763,7 @@ int rtw_chk_start_clnt_join(struct adapter *padapter, u8 *ch, u8 *bw, u8 *offset 
		*offset = cur_ch_offset;

	}



	return connect_allow == true ? _SUCCESS : _FAIL;

	return connect_allow ? _SUCCESS : _FAIL;

}



/* Find union about ch, bw, ch_offset of all linked/linking interfaces */

CRA Git | Maintained and supported by SUSTech CRA and CCSE