xhci: fix SCT_FOR_CTX(p) macro (63a67a72) · Commits · 戴 / test

SCT_FOR_CTX(p) is defined as (((p) << 1) & 0x7) in which case if we want to set the stream context type to SCT_SSA_256 i.e 0x7 (although secondary stream arrays are not yet supported) using this macro definition we will get actually 0x6 which is not what we want. This patch fixes the above issue by defining the SCT_FOR_CTX(p) macro as (((p) & 0x7) << 1) Signed-off-by:

Xenia Ragiadakou <burzalodowa@gmail.com> Signed-off-by:

Sarah Sharp <sarah.a.sharp@linux.intel.com>

drivers/usb/host/xhci.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -752,7 +752,7 @@ struct xhci_stream_ctx {
	};		};

	/* Stream Context Types (section 6.4.1) - bits 3:1 of stream ctx deq ptr */		/* Stream Context Types (section 6.4.1) - bits 3:1 of stream ctx deq ptr */
	#define SCT_FOR_CTX(p) (((p) << 1) & 0x7)		#define SCT_FOR_CTX(p) (((p) & 0x7) << 1)
	/* Secondary stream array type, dequeue pointer is to a transfer ring */		/* Secondary stream array type, dequeue pointer is to a transfer ring */
	#define SCT_SEC_TR 0		#define SCT_SEC_TR 0
	/* Primary stream array type, dequeue pointer is to a transfer ring */		/* Primary stream array type, dequeue pointer is to a transfer ring */

Admin message