Commit 639812a1 authored Oct 09, 2017 by Josef Bacik Committed by Jens Axboe Oct 09, 2017

nbd: don't set the device size until we're connected



A user reported a regression with using the normal ioctl interface on
newer kernels.  This happens because I was setting the device size
before the device was actually connected, which caused us to error out
and close everything down.  This didn't happen on netlink because we
hold the device lock the whole time we're setting things up, but we
don't do that for the ioctl path.  This fixes the problem.

Cc: stable@vger.kernel.org
Fixes: 29eaadc0 ("nbd: stop using the bdev everywhere")
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 09aa97c7

drivers/block/nbd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -243,7 +243,6 @@ static void nbd_size_set(struct nbd_device *nbd, loff_t blocksize,
		struct nbd_config *config = nbd->config;
		config->blksize = blocksize;
		config->bytesize = blocksize * nr_blocks;
		nbd_size_update(nbd);
		}

		static void nbd_complete_rq(struct request *req)
		@@ -1094,6 +1093,7 @@ static int nbd_start_device(struct nbd_device *nbd)
		args->index = i;
		queue_work(recv_workqueue, &args->work);
		}
		nbd_size_update(nbd);
		return error;
		}

Admin message