Commit 6396feab authored Aug 19, 2020 by Moti Haimovski Committed by Oded Gabbay Aug 31, 2020

habanalabs: prevent user buff overflow



This commit fixes a potential debugfs issue that may occur when
reading the clock gating mask into the user buffer since the
user buffer size was not taken into consideration.

Signed-off-by: Moti Haimovski <mhaimovski@habana.ai>
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>

parent f75aef39

drivers/misc/habanalabs/common/debugfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -982,7 +982,7 @@ static ssize_t hl_clk_gate_read(struct file f, char __user buf,
		return 0;

		sprintf(tmp_buf, "0x%llx\n", hdev->clock_gating_mask);
		rc = simple_read_from_buffer(buf, strlen(tmp_buf) + 1, ppos, tmp_buf,
		rc = simple_read_from_buffer(buf, count, ppos, tmp_buf,
		strlen(tmp_buf) + 1);

		return rc;

Admin message