Commit 63847600 authored Dec 16, 2014 by Xunlei Pang Committed by Ingo Molnar Jan 14, 2015

sched/fair: Fix the dealing with decay_count in __synchronize_entity_decay()



In __synchronize_entity_decay(), if "decays" happens to be zero,
se->avg.decay_count will not be zeroed, holding the positive value
assigned when dequeued last time.

This is problematic in the following case:
If this runnable task is CFS-balanced to other CPUs soon afterwards,
migrate_task_rq_fair() will treat it as a blocked task due to its
non-zero decay_count, thereby adding its load to cfs_rq->removed_load
wrongly.

Thus, we must zero se->avg.decay_count in this case as well.

Signed-off-by: Xunlei Pang <pang.xunlei@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Ben Segall <bsegall@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1418745509-2609-1-git-send-email-pang.xunlei@linaro.org


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 7f1a169b

kernel/sched/fair.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2574,11 +2574,11 @@ static inline u64 __synchronize_entity_decay(struct sched_entity *se)
		u64 decays = atomic64_read(&cfs_rq->decay_counter);

		decays -= se->avg.decay_count;
		se->avg.decay_count = 0;
		if (!decays)
		return 0;

		se->avg.load_avg_contrib = decay_load(se->avg.load_avg_contrib, decays);
		se->avg.decay_count = 0;

		return decays;
		}

Admin message