Commit 63781394 authored May 11, 2015 by Axel Lin Committed by Thomas Gleixner May 13, 2015

genirq: devres: Fix testing return value of request_any_context_irq()



request_any_context_irq() returns a negative value on failure.
It returns either IRQC_IS_HARDIRQ or IRQC_IS_NESTED on success.
So fix testing return value of request_any_context_irq().

Also fixup the return value of devm_request_any_context_irq() to make it
consistent with request_any_context_irq().

Fixes: 0668d306 ("genirq: Add devm_request_any_context_irq()")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1431334978.17783.4.camel@ingics.com


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent dbf07cf0

kernel/irq/devres.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -104,7 +104,7 @@ int devm_request_any_context_irq(struct device *dev, unsigned int irq,
		return -ENOMEM;

		rc = request_any_context_irq(irq, handler, irqflags, devname, dev_id);
		if (rc) {
		if (rc < 0) {
		devres_free(dr);
		return rc;
		}
		@@ -113,7 +113,7 @@ int devm_request_any_context_irq(struct device *dev, unsigned int irq,
		dr->dev_id = dev_id;
		devres_add(dev, dr);

		return 0;
		return rc;
		}
		EXPORT_SYMBOL(devm_request_any_context_irq);

Admin message