Commit 6376b229 authored by Namhyung Kim's avatar Namhyung Kim Committed by Ingo Molnar
Browse files

kprobes: Make functions static 



Make following (internal) functions static to make sparse
happier :-)

 * get_optimized_kprobe: only called from static functions
 * kretprobe_table_unlock: _lock function is static
 * kprobes_optinsn_template_holder: never called but holding asm code

Signed-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
Acked-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
LKML-Reference: <1284512670-2369-4-git-send-email-namhyung@gmail.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 05662bdb

arch/x86/kernel/kprobes.c

+1 −1
Original line number Diff line number Diff line
@@ -1129,7 +1129,7 @@ static void __kprobes synthesize_set_arg1(kprobe_opcode_t *addr, 
	*(unsigned long *)addr = val;

}



void __kprobes kprobes_optinsn_template_holder(void)

static void __used __kprobes kprobes_optinsn_template_holder(void)

{

	asm volatile (

			".global optprobe_template_entry\n"

kernel/kprobes.c

+3 −2
Original line number Diff line number Diff line
@@ -399,7 +399,7 @@ static inline int kprobe_optready(struct kprobe *p) 
 * Return an optimized kprobe whose optimizing code replaces

 * instructions including addr (exclude breakpoint).

 */

struct kprobe *__kprobes get_optimized_kprobe(unsigned long addr)

static struct kprobe *__kprobes get_optimized_kprobe(unsigned long addr)

{

	int i;

	struct kprobe *p = NULL;
@@ -857,7 +857,8 @@ void __kprobes kretprobe_hash_unlock(struct task_struct *tsk, 
	spin_unlock_irqrestore(hlist_lock, *flags);

}



void __kprobes kretprobe_table_unlock(unsigned long hash, unsigned long *flags)

static void __kprobes kretprobe_table_unlock(unsigned long hash,

       unsigned long *flags)

{

	spinlock_t *hlist_lock = kretprobe_table_lock_ptr(hash);

	spin_unlock_irqrestore(hlist_lock, *flags);

CRA Git | Maintained and supported by SUSTech CRA and CCSE