Commit 636edeaa authored by Alex Elder's avatar Alex Elder Committed by David S. Miller
Browse files

net: ipa: program upper nibbles of sequencer type 



The upper two nibbles of the sequencer type were not used for
SDM845, and were assumed to be 0.  But for SC7180 they are used, and
so they must be programmed by ipa_endpoint_init_seq().  Fix this bug.

IPA_SEQ_PKT_PROCESS_NO_DEC_NO_UCP_DMAP doesn't have a descriptive
comment, so add one.

Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9b8ad8da

drivers/net/ipa/ipa_endpoint.c

+4 −2
Original line number Diff line number Diff line
@@ -699,10 +699,12 @@ static void ipa_endpoint_init_seq(struct ipa_endpoint *endpoint) 
	u32 seq_type = endpoint->seq_type;

	u32 val = 0;



	/* Sequencer type is made up of four nibbles */

	val |= u32_encode_bits(seq_type & 0xf, HPS_SEQ_TYPE_FMASK);

	val |= u32_encode_bits((seq_type >> 4) & 0xf, DPS_SEQ_TYPE_FMASK);

	/* HPS_REP_SEQ_TYPE is 0 */

	/* DPS_REP_SEQ_TYPE is 0 */

	/* The second two apply to replicated packets */

	val |= u32_encode_bits((seq_type >> 8) & 0xf, HPS_REP_SEQ_TYPE_FMASK);

	val |= u32_encode_bits((seq_type >> 12) & 0xf, DPS_REP_SEQ_TYPE_FMASK);



	iowrite32(val, endpoint->ipa->reg_virt + offset);

}

drivers/net/ipa/ipa_reg.h

+2 −0
Original line number Diff line number Diff line
@@ -455,6 +455,8 @@ enum ipa_mode { 
 *	second packet processing pass + no decipher + microcontroller

 * @IPA_SEQ_DMA_DEC:		DMA + cipher/decipher

 * @IPA_SEQ_DMA_COMP_DECOMP:	DMA + compression/decompression

 * @IPA_SEQ_PKT_PROCESS_NO_DEC_NO_UCP_DMAP:

 *	packet processing + no decipher + no uCP + HPS REP DMA parser

 * @IPA_SEQ_INVALID:		invalid sequencer type

 *

 * The values defined here are broken into 4-bit nibbles that are written

CRA Git | Maintained and supported by SUSTech CRA and CCSE