Unverified Commit 635093e3 authored Jul 29, 2020 by Atish Patra Committed by Palmer Dabbelt Aug 04, 2020

RISC-V: Fix build warning for smpboot.c



The following warnings are reported by kbuild with W=1.

>> arch/riscv/kernel/smpboot.c:109:5: warning: no previous prototype for
'start_secondary_cpu' [-Wmissing-prototypes]
     109 | int start_secondary_cpu(int cpu, struct task_struct *tidle)
         |     ^~~~~~~~~~~~~~~~~~~
   arch/riscv/kernel/smpboot.c:146:34: warning: no previous prototype for
'smp_callin' [-Wmissing-prototypes]
     146 | asmlinkage __visible void __init smp_callin(void)
         |                                  ^~~~~~~~~~

Fix the warnings by marking the local functions static and adding the prototype
for the global function.

Signed-off-by: Atish Patra <atish.patra@wdc.com>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>

parent 3843aca0

arch/riscv/include/asm/smp.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -40,6 +40,9 @@ void arch_send_call_function_single_ipi(int cpu);
		int riscv_hartid_to_cpuid(int hartid);
		void riscv_cpuid_to_hartid_mask(const struct cpumask in, struct cpumask out);

		/* Secondary hart entry */
		asmlinkage void smp_callin(void);

		/*
		* Obtains the hart ID of the currently executing task. This relies on
		* THREAD_INFO_IN_TASK, but we define that unconditionally.

arch/riscv/kernel/smpboot.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -106,7 +106,7 @@ void __init setup_smp(void)
		}
		}

		int start_secondary_cpu(int cpu, struct task_struct *tidle)
		static int start_secondary_cpu(int cpu, struct task_struct *tidle)
		{
		if (cpu_ops[cpu]->cpu_start)
		return cpu_ops[cpu]->cpu_start(cpu, tidle);

Admin message