Commit 634b0e04 authored Apr 19, 2017 by Vikas Shivappa Committed by Thomas Gleixner Apr 20, 2017

x86/intel_rdt: Trim whitespace while parsing schemata input



Schemata is displayed in tabular format which introduces some whitespace
to show data in a tabular format.

Writing back the same data fails as the parser does not handle the
whitespace.

Trim the leading and trailing whitespace before parsing.

Reported-by: Prakhya, Sai Praneeth <sai.praneeth.prakhya@intel.com>
Signed-off-by: Vikas Shivappa <vikas.shivappa@linux.intel.com>
Tested-by: Prakhya, Sai Praneeth <sai.praneeth.prakhya@intel.com>
Cc: fenghua.yu@intel.com
Cc: tony.luck@intel.com
Cc: ravi.v.shankar@intel.com
Cc: vikas.shivappa@intel.com
Link: http://lkml.kernel.org/r/1492645804-17465-3-git-send-email-vikas.shivappa@linux.intel.com


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent adcbdd70

arch/x86/kernel/cpu/intel_rdt_schemata.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -141,6 +141,7 @@ next:
		id = strsep(&dom, "=");
		if (!dom \|\| kstrtoul(id, 10, &dom_id))
		return -EINVAL;
		dom = strim(dom);
		list_for_each_entry(d, &r->domains, list) {
		if (d->id == dom_id) {
		if (r->parse_ctrlval(dom, r, d))
		@@ -214,7 +215,7 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file *of,
		dom->have_new_ctrl = false;

		while ((tok = strsep(&buf, "\n")) != NULL) {
		resname = strsep(&tok, ":");
		resname = strim(strsep(&tok, ":"));
		if (!tok) {
		ret = -EINVAL;
		goto out;

Admin message