Commit 63337b63 authored Mar 27, 2020 by Kaixu Xia Committed by Darrick J. Wong Mar 28, 2020

xfs: remove unnecessary ternary from xfs_create



Since the "no-allocation" reservations for file creations has
been removed, the resblks value should be larger than zero, so
remove unnecessary ternary conditional.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
[darrick: s/judgment/ternary/]
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 5cc3c006

fs/xfs/xfs_inode.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1200,8 +1200,7 @@ xfs_create(
		unlock_dp_on_error = false;

		error = xfs_dir_createname(tp, dp, name, ip->i_ino,
		resblks ?
		resblks - XFS_IALLOC_SPACE_RES(mp) : 0);
		resblks - XFS_IALLOC_SPACE_RES(mp));
		if (error) {
		ASSERT(error != -ENOSPC);
		goto out_trans_cancel;

Admin message