Commit 6316f51c authored by Huang Rui's avatar Huang Rui Committed by Alex Deucher
Browse files

drm/amd/powerplay: remove unnecessary checking in smu_hw_fini 



This patch removes unnecessary NULL pointer checking in smu_hw_fini, because
kfree is able to handle NULL pointer case.

Suggested-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: default avatarHuang Rui <ray.huang@amd.com>
Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
Reviewed-by: default avatarKevin Wang <kevin1.wang@amd.com>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c4d74f53

drivers/gpu/drm/amd/powerplay/amdgpu_smu.c

+14 −28
Original line number Diff line number Diff line
@@ -683,40 +683,26 @@ static int smu_hw_fini(void *handle) 
	if (!is_support_sw_smu(adev))

		return -EINVAL;



	if (table_context->driver_pptable) {

	kfree(table_context->driver_pptable);

	table_context->driver_pptable = NULL;

	}



	if (table_context->max_sustainable_clocks) {

	kfree(table_context->max_sustainable_clocks);

	table_context->max_sustainable_clocks = NULL;

	}



	if (table_context->od_feature_capabilities) {

	kfree(table_context->od_feature_capabilities);

	table_context->od_feature_capabilities = NULL;

	}



	if (table_context->od_settings_max) {

	kfree(table_context->od_settings_max);

	table_context->od_settings_max = NULL;

	}



	if (table_context->od_settings_min) {

	kfree(table_context->od_settings_min);

	table_context->od_settings_min = NULL;

	}



	if (table_context->overdrive_table) {

	kfree(table_context->overdrive_table);

	table_context->overdrive_table = NULL;

	}



	if (table_context->od8_settings) {

	kfree(table_context->od8_settings);

	table_context->od8_settings = NULL;

	}



	ret = smu_fini_fb_allocations(smu);

	if (ret)

CRA Git | Maintained and supported by SUSTech CRA and CCSE