Commit 630d4e75 authored Nov 06, 2019 by Wei Yongjun Committed by David S. Miller Nov 07, 2019

mlxsw: spectrum: Fix error return code in mlxsw_sp_port_module_info_init()



Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 4a7f970f ("mlxsw: spectrum: Replace port_to_module array with array of structs")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 69625ea7

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -4079,9 +4079,11 @@ static int mlxsw_sp_port_module_info_init(struct mlxsw_sp *mlxsw_sp)
		mlxsw_sp->port_mapping[i] = kmemdup(&port_mapping,
		sizeof(port_mapping),
		GFP_KERNEL);
		if (!mlxsw_sp->port_mapping[i])
		if (!mlxsw_sp->port_mapping[i]) {
		err = -ENOMEM;
		goto err_port_module_info_dup;
		}
		}
		return 0;

		err_port_module_info_get:

Admin message