Commit 62f2a3a4 authored by Michał Mirosław's avatar Michał Mirosław Committed by David S. Miller
Browse files

net: remove NETIF_F_ALL_TX_OFFLOADS 



There is no software fallback implemented for SCTP or FCoE checksumming,
and so it should not be passed on by software devices like bridge or bonding.

For VLAN devices, this is different. First, the driver for underlying device
should be prepared to get offloaded packets even when the feature is disabled
(especially if it advertises it in vlan_features). Second, devices under
VLANs do not get replaced without tearing down the VLAN first.

This fixes a mess I accidentally introduced while converting bonding to
ndo_fix_features.

NETIF_F_SOFT_FEATURES are removed from BOND_VLAN_FEATURES because they
are unused as of commit 712ae51a.

Signed-off-by: default avatarMichał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b73c43f8

drivers/net/bonding/bond_main.c

+3 −3
Original line number Diff line number Diff line
@@ -1428,9 +1428,9 @@ out: 
	return features;

}



#define BOND_VLAN_FEATURES	(NETIF_F_ALL_TX_OFFLOADS | \

				 NETIF_F_SOFT_FEATURES | \

				 NETIF_F_LRO)

#define BOND_VLAN_FEATURES	(NETIF_F_ALL_CSUM | NETIF_F_SG | \

				 NETIF_F_FRAGLIST | NETIF_F_ALL_TSO | \

				 NETIF_F_HIGHDMA | NETIF_F_LRO)



static void bond_compute_features(struct bonding *bond)

{

include/linux/netdevice.h

+0 −6
Original line number Diff line number Diff line
@@ -1097,12 +1097,6 @@ struct net_device { 
#define NETIF_F_ALL_FCOE	(NETIF_F_FCOE_CRC | NETIF_F_FCOE_MTU | \

				 NETIF_F_FSO)



#define NETIF_F_ALL_TX_OFFLOADS	(NETIF_F_ALL_CSUM | NETIF_F_SG | \

				 NETIF_F_FRAGLIST | NETIF_F_ALL_TSO | \

				 NETIF_F_HIGHDMA | \

				 NETIF_F_SCTP_CSUM | \

				 NETIF_F_ALL_FCOE)



	/*

	 * If one device supports one of these features, then enable them

	 * for all in netdev_increment_features.

net/8021q/vlan_dev.c

+5 −1
Original line number Diff line number Diff line
@@ -528,7 +528,11 @@ static int vlan_dev_init(struct net_device *dev) 
					  (1<<__LINK_STATE_DORMANT))) |

		      (1<<__LINK_STATE_PRESENT);



	dev->hw_features = NETIF_F_ALL_TX_OFFLOADS;

	dev->hw_features = NETIF_F_ALL_CSUM | NETIF_F_SG |

			   NETIF_F_FRAGLIST | NETIF_F_ALL_TSO |

			   NETIF_F_HIGHDMA | NETIF_F_SCTP_CSUM |

			   NETIF_F_ALL_FCOE;



	dev->features |= real_dev->vlan_features | NETIF_F_LLTX;

	dev->gso_max_size = real_dev->gso_max_size;

CRA Git | Maintained and supported by SUSTech CRA and CCSE