MIPS: ralink: Make timer explicitly non-modular (62ee73d2) · Commits · 戴 / test

The Makefile entry controlling compilation of this code is "obj-y" meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. We explicitly disallow a driver unbind, since that doesn't have a sensible use case anyway, and it allows us to drop the ".remove" code for non-modular drivers. Since module_platform_driver() uses the same init level priority as builtin_platform_driver() the init ordering remains unchanged with this commit. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. We also delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments. We don't replace module.h with init.h since the file already has that. Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com> Cc: John Crispin <john@phrozen.org> Cc: linux-mips@linux-mips.org Patchwork: https://patchwork.linux-mips.org/patch/13931/ Signed-off-by:

Ralf Baechle <ralf@linux-mips.org>

arch/mips/ralink/timer.c

+7 −21

Original line number	Diff line number	Diff line
		/*
		* Ralink RT2880 timer
		* Author: John Crispin
		*
		* This program is free software; you can redistribute it and/or modify it
		* under the terms of the GNU General Public License version 2 as published
		* by the Free Software Foundation.
		@@ -6,7 +9,6 @@
		* Copyright (C) 2013 John Crispin <john@phrozen.org>
		*/

		#include <linux/module.h>
		#include <linux/platform_device.h>
		#include <linux/interrupt.h>
		#include <linux/timer.h>
		@@ -152,33 +154,17 @@ static int rt_timer_probe(struct platform_device *pdev)
		return 0;
		}

		static int rt_timer_remove(struct platform_device *pdev)
		{
		struct rt_timer *rt = platform_get_drvdata(pdev);

		rt_timer_disable(rt);
		rt_timer_free(rt);

		return 0;
		}

		static const struct of_device_id rt_timer_match[] = {
		{ .compatible = "ralink,rt2880-timer" },
		{},
		};
		MODULE_DEVICE_TABLE(of, rt_timer_match);

		static struct platform_driver rt_timer_driver = {
		.probe = rt_timer_probe,
		.remove = rt_timer_remove,
		.driver = {
		.name = "rt-timer",
		.of_match_table = rt_timer_match
		.of_match_table = rt_timer_match,
		.suppress_bind_attrs = true,
		},
		};

		module_platform_driver(rt_timer_driver);

		MODULE_DESCRIPTION("Ralink RT2880 timer");
		MODULE_AUTHOR("John Crispin <john@phrozen.org");
		MODULE_LICENSE("GPL");
		builtin_platform_driver(rt_timer_driver);

Admin message