Commit 62d9a78f authored Sep 13, 2016 by Yongji Xie Committed by Bjorn Helgaas Sep 28, 2016

PCI: Ignore requested alignment for VF BARs



Resource allocation for VFs is done via the VF BARx registers in the PF's
SR-IOV Capability, and the BARs in the VFs themselves are read-only zeros
(see SR-IOV spec r1.1, secs 3.3.14 and 3.4.1.11).

Even though the actual VF BARs are read-only zeros, the VF dev->resource[]
structs describe the space allocated for the VF (this is a piece of the
space described by the VF BARx register in the PF's SR-IOV capability).

It's meaningless to request additional alignment for a VF: the VF BAR
alignment is completely determined by the alignment of the VF BARx in the
PF and the size of the VF BAR.

Ignore the user's alignment requests for VF devices.

Signed-off-by: Yongji Xie <xyjxie@linux.vnet.ibm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent f0b99f70

drivers/pci/pci.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -5049,6 +5049,15 @@ void pci_reassigndev_resource_alignment(struct pci_dev *dev)
		resource_size_t align, size;
		u16 command;

		/*
		* VF BARs are read-only zero according to SR-IOV spec r1.1, sec
		* 3.4.1.11. Their resources are allocated from the space
		* described by the VF BARx register in the PF's SR-IOV capability.
		* We can't influence their alignment here.
		*/
		if (dev->is_virtfn)
		return;

		/* check if specified PCI is target device to reassign */
		align = pci_specified_resource_alignment(dev);
		if (!align)

Admin message