Commit 62d0fd59 authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

arch: split MODULE_ARCH_VERMAGIC definitions out to <asm/vermagic.h> 

As the bug report [1] pointed out, <linux/vermagic.h> must be included
after <linux/module.h>.

I believe we should not impose any include order restriction. We often
sort include directives alphabetically, but it is just coding style
convention. Technically, we can include header files in any order by
making every header self-contained.

Currently, arch-specific MODULE_ARCH_VERMAGIC is defined in
<asm/module.h>, which is not included from <linux/vermagic.h>.

Hence, the straight-forward fix-up would be as follows:

|--- a/include/linux/vermagic.h
|+++ b/include/linux/vermagic.h
|@@ -1,5 +1,6 @@
| /* SPDX-License-Identifier: GPL-2.0 */
| #include <generated/utsrelease.h>
|+#include <linux/module.h>
|
| /* Simply sanity version stamp for modules. */
| #ifdef CONFIG_SMP

This works enough, but for further cleanups, I split MODULE_ARCH_VERMAGIC
definitions into <asm/vermagic.h>.

With this, <linux/module.h> and <linux/vermagic.h> will be orthogonal,
and the location of MODULE_ARCH_VERMAGIC definitions will be consistent.

For arc and ia64, MODULE_PROC_FAMILY is only used for defining
MODULE_ARCH_VERMAGIC. I squashed it.

For hexagon, nds32, and xtensa, I removed <asm/modules.h> entirely
because they contained nothing but MODULE_ARCH_VERMAGIC definition.
Kbuild will automatically generate <asm/modules.h> at build-time,
wrapping <asm-generic/module.h>.

[1] https://lore.kernel.org/lkml/20200411155623.GA22175@zn.tnic



Reported-by: default avatarBorislav Petkov <bp@suse.de>
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Acked-by: default avatarJessica Yu <jeyu@kernel.org>
parent 3d4b2238

arch/arc/include/asm/module.h

+0 −5
Original line number Diff line number Diff line
@@ -3,7 +3,6 @@ 
 * Copyright (C) 2004, 2007-2010, 2011-2012 Synopsys, Inc. (www.synopsys.com)

 *

 * Amit Bhor, Sameer Dhavale: Codito Technologies 2004



 */



#ifndef _ASM_ARC_MODULE_H
@@ -19,8 +18,4 @@ struct mod_arch_specific { 
	const char *secstr;

};



#define MODULE_PROC_FAMILY "ARC700"



#define MODULE_ARCH_VERMAGIC MODULE_PROC_FAMILY



#endif /* _ASM_ARC_MODULE_H */

arch/arc/include/asm/vermagic.h

0 → 100644
+8 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */



#ifndef _ASM_VERMAGIC_H

#define _ASM_VERMAGIC_H



#define MODULE_ARCH_VERMAGIC "ARC700"



#endif /* _ASM_VERMAGIC_H */

arch/arm/include/asm/module.h

+0 −24
Original line number Diff line number Diff line
@@ -37,30 +37,6 @@ struct mod_arch_specific { 
struct module;

u32 get_module_plt(struct module *mod, unsigned long loc, Elf32_Addr val);



/*

 * Add the ARM architecture version to the version magic string

 */

#define MODULE_ARCH_VERMAGIC_ARMVSN "ARMv" __stringify(__LINUX_ARM_ARCH__) " "



/* Add __virt_to_phys patching state as well */

#ifdef CONFIG_ARM_PATCH_PHYS_VIRT

#define MODULE_ARCH_VERMAGIC_P2V "p2v8 "

#else

#define MODULE_ARCH_VERMAGIC_P2V ""

#endif



/* Add instruction set architecture tag to distinguish ARM/Thumb kernels */

#ifdef CONFIG_THUMB2_KERNEL

#define MODULE_ARCH_VERMAGIC_ARMTHUMB "thumb2 "

#else

#define MODULE_ARCH_VERMAGIC_ARMTHUMB ""

#endif



#define MODULE_ARCH_VERMAGIC \

	MODULE_ARCH_VERMAGIC_ARMVSN \

	MODULE_ARCH_VERMAGIC_ARMTHUMB \

	MODULE_ARCH_VERMAGIC_P2V



#ifdef CONFIG_THUMB2_KERNEL

#define HAVE_ARCH_KALLSYMS_SYMBOL_VALUE

static inline unsigned long kallsyms_symbol_value(const Elf_Sym *sym)

arch/arm/include/asm/vermagic.h

0 → 100644
+31 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

#ifndef _ASM_VERMAGIC_H

#define _ASM_VERMAGIC_H



#include <linux/stringify.h>



/*

 * Add the ARM architecture version to the version magic string

 */

#define MODULE_ARCH_VERMAGIC_ARMVSN "ARMv" __stringify(__LINUX_ARM_ARCH__) " "



/* Add __virt_to_phys patching state as well */

#ifdef CONFIG_ARM_PATCH_PHYS_VIRT

#define MODULE_ARCH_VERMAGIC_P2V "p2v8 "

#else

#define MODULE_ARCH_VERMAGIC_P2V ""

#endif



/* Add instruction set architecture tag to distinguish ARM/Thumb kernels */

#ifdef CONFIG_THUMB2_KERNEL

#define MODULE_ARCH_VERMAGIC_ARMTHUMB "thumb2 "

#else

#define MODULE_ARCH_VERMAGIC_ARMTHUMB ""

#endif



#define MODULE_ARCH_VERMAGIC \

	MODULE_ARCH_VERMAGIC_ARMVSN \

	MODULE_ARCH_VERMAGIC_ARMTHUMB \

	MODULE_ARCH_VERMAGIC_P2V



#endif /* _ASM_VERMAGIC_H */

arch/arm64/include/asm/module.h

+0 −2
Original line number Diff line number Diff line
@@ -7,8 +7,6 @@ 


#include <asm-generic/module.h>



#define MODULE_ARCH_VERMAGIC	"aarch64"



#ifdef CONFIG_ARM64_MODULE_PLTS

struct mod_plt_sec {

	int			plt_shndx;

CRA Git | Maintained and supported by SUSTech CRA and CCSE