Commit 62a38e70 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Jason Gunthorpe
Browse files

RDMA/efa: Remove check that prevents destroy of resources in error flows 



Drivers cannot check the udata for validity when doing destroy as there
will be no way to report this error back to the uverbs.

Since udata is new for destroy no driver should start to use it - instead
drivers should opt for the ioctl interface and define it in a way where it
cannot fail due to incorrect data.

Remove the checks on udata construction so EFA is consistent with
everything else.

Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Acked-by: default avatarGal Pressman <galpress@amazon.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent dab99af9

drivers/infiniband/hw/efa/efa_verbs.c

+0 −24
Original line number Diff line number Diff line
@@ -436,12 +436,6 @@ void efa_dealloc_pd(struct ib_pd *ibpd, struct ib_udata *udata) 
	struct efa_dev *dev = to_edev(ibpd->device);

	struct efa_pd *pd = to_epd(ibpd);



	if (udata->inlen &&

	    !ib_is_udata_cleared(udata, 0, udata->inlen)) {

		ibdev_dbg(&dev->ibdev, "Incompatible ABI params\n");

		return;

	}



	ibdev_dbg(&dev->ibdev, "Dealloc pd[%d]\n", pd->pdn);

	efa_pd_dealloc(dev, pd->pdn);

}
@@ -459,12 +453,6 @@ int efa_destroy_qp(struct ib_qp *ibqp, struct ib_udata *udata) 
	struct efa_qp *qp = to_eqp(ibqp);

	int err;



	if (udata->inlen &&

	    !ib_is_udata_cleared(udata, 0, udata->inlen)) {

		ibdev_dbg(&dev->ibdev, "Incompatible ABI params\n");

		return -EINVAL;

	}



	ibdev_dbg(&dev->ibdev, "Destroy qp[%u]\n", ibqp->qp_num);

	err = efa_destroy_qp_handle(dev, qp->qp_handle);

	if (err)
@@ -865,12 +853,6 @@ int efa_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) 
	struct efa_cq *cq = to_ecq(ibcq);

	int err;



	if (udata->inlen &&

	    !ib_is_udata_cleared(udata, 0, udata->inlen)) {

		ibdev_dbg(&dev->ibdev, "Incompatible ABI params\n");

		return -EINVAL;

	}



	ibdev_dbg(&dev->ibdev,

		  "Destroy cq[%d] virt[0x%p] freed: size[%lu], dma[%pad]\n",

		  cq->cq_idx, cq->cpu_addr, cq->size, &cq->dma_addr);
@@ -1556,12 +1538,6 @@ int efa_dereg_mr(struct ib_mr *ibmr, struct ib_udata *udata) 
	struct efa_mr *mr = to_emr(ibmr);

	int err;



	if (udata->inlen &&

	    !ib_is_udata_cleared(udata, 0, udata->inlen)) {

		ibdev_dbg(&dev->ibdev, "Incompatible ABI params\n");

		return -EINVAL;

	}



	ibdev_dbg(&dev->ibdev, "Deregister mr[%d]\n", ibmr->lkey);



	if (mr->umem) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE