Commit 627469e4 authored Nov 06, 2018 by Jia-Ju Bai Committed by Vinod Koul Nov 24, 2018

dmaengine: coh901318: Fix a double-lock bug



The function coh901318_alloc_chan_resources() calls spin_lock_irqsave()
before calling coh901318_config().
But coh901318_config() calls spin_lock_irqsave() again in its
definition, which may cause a double-lock bug.

Because coh901318_config() is only called by
coh901318_alloc_chan_resources(), the bug fix is to remove the
calls to spin-lock and -unlock functions in coh901318_config().

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 65102238

drivers/dma/coh901318.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1807,8 +1807,6 @@ static int coh901318_config(struct coh901318_chan *cohc,
		int channel = cohc->id;
		void __iomem *virtbase = cohc->base->virtbase;

		spin_lock_irqsave(&cohc->lock, flags);

		if (param)
		p = param;
		else
		@@ -1828,8 +1826,6 @@ static int coh901318_config(struct coh901318_chan *cohc,
		coh901318_set_conf(cohc, p->config);
		coh901318_set_ctrl(cohc, p->ctrl_lli_last);

		spin_unlock_irqrestore(&cohc->lock, flags);

		return 0;
		}

Admin message